Force openfoam only use Opt build type

[appolloford]

(created using eb --new-pr)

[Micket]

Not much description here. I'm guessing this is to make it consistent with the meaning of "debug" in toolchain options? I.e. debug is supposed to mean only debug symbols, not a debug build.

Ideally, the easyblock should respect lowopt/noopt options that should reflect a debug type build scenario, though i suppoe the old code in the easyblock didn't do that either?

[boegel]

Hmm, I don't see a need for this, especially in EasyBuild 5.0 where we have a global setting to determine the value of the debug toolchain option (which is disabled by default).

What's the motivation for this exactly?

[Micket]

        if self.toolchain.options['debug']:
            self.build_type = 'Debug'

is just wrong logic. self.toolchain.options['debug'] means "enable_debug_symbols"

        if self.toolchain.options['noopt']:
            self.build_type = 'Debug'

would be appropriate.

[appolloford]

Since EB5 uses debug symbol in toolchains by default. The original OpenFOAM easyblock captures the value and sets the build type to 'debug' and use the build-in debug flags such as the c++Debug file:

c++DBUG     = -ggdb3 -DFULLDEBUG
c++OPT      = -O0 -fdefault-inline

I think here are two problems:

1. debug symbol should not cause OpenFOAM built in -O0 and have additional debug messages from -DFULLDEBUG
2. EB always sets build FLAGS in environment variables so easyblock should always use the FLAGS set by EB. There should be no need to use the FLAGS come from OpenFOAM itself.
   If there is a need to have -DFULLDEBUG, I think this should be passed as a buildopt

To summary, the PR would like to force EB always use Opt case as this is the only one which passes the EB environment variables into their wmake in current openfoam easyblock

[boegel]

@appolloford I changed to target branch in this PR from 5.0.x to develop, you should synchronize your PR branch with current develop branch (which has received a massive update after the release of EasyBuild v5.0.0, see #3670)

[appolloford]

I don't think anything in this PR is affected by the synchronization.