Merge of the ConfigureMake and CMakeMake versions of the easyblock for QuantumESPRESSO#3338
Conversation
5617ae1 to
456e5d4
Compare
456e5d4 to
7f9134f
Compare
|
@boegel I tried merging the 2 easyblocks for QuantumESPRESSO into a new one acting as a wrapper and forwarding the calls to the correct EB based on the version. It is slightly hackish but still very clean code-wise. Unfortunately The alternatives would be to either define the classes inside something like another class (or the wrapper class itself) or a dict (anything that will let class not be at the beginning of the string to trick the Any suggestion in which direction to proceed? |
|
This is extensively tested in easybuilders/easybuild-easyconfigs#20070 and easybuilders/easybuild-easyconfigs#20138 |
…stem/site libraries to take precedence over EB ones
505eca8 to
f9df434
Compare
f9df434 to
5f95e61
Compare
|
Put version specific classes inside the wrapper as to not have trouble with framework EB detection regex |
ocaisa
left a comment
There was a problem hiding this comment.
This has been extensively tested via easybuilders/easybuild-easyconfigs#20138 and easybuilders/easybuild-easyconfigs#20070 (comment)
The QuantumESPRESSO
ConfigMakeandCMakeMakeeasyblocks have been merged in the same file with a wrapper easyblock deciding which one will get used depending on the version of QE.This PR would