Archive autotools-based QuantumESPRESSO easyblock and switch default to CMakeMake-based easyblock#3306
Closed
ocaisa wants to merge 6 commits intoeasybuilders:developfrom
Closed
Archive autotools-based QuantumESPRESSO easyblock and switch default to CMakeMake-based easyblock#3306ocaisa wants to merge 6 commits intoeasybuilders:developfrom
ocaisa wants to merge 6 commits intoeasybuilders:developfrom
Conversation
…to CMakeMake-based easyblock
Member
Author
|
@boegel I've got the test suite passing for this now |
ocaisa
commented
May 10, 2024
Comment on lines
+191
to
+193
| if LooseVersion(self.version) == LooseVersion('7.3.1'): | ||
| # See issue: https://github.com/dceresoli/qe-gipaw/issues/19 | ||
| raise EasyBuildError('GIPAW will fail to compile in QE 7.3.1') |
Member
Author
There was a problem hiding this comment.
Suggested change
| if LooseVersion(self.version) == LooseVersion('7.3.1'): | |
| # See issue: https://github.com/dceresoli/qe-gipaw/issues/19 | |
| raise EasyBuildError('GIPAW will fail to compile in QE 7.3.1') | |
| if LooseVersion(self.version) == LooseVersion('7.3.1'): | |
| # See issue: https://github.com/dceresoli/qe-gipaw/issues/19 | |
| raise EasyBuildError('GIPAW will fail to compile in QE 7.3.1') |
No longer necessary due to the change in easybuilders/easybuild-easyconfigs@a563666
ocaisa
commented
May 10, 2024
Member
Author
|
Closing this in favour of #3338 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will require updating all of the Quantum ESPRESSO easyconfigs, so is a draft until those are also ready to merge (both should be done at the same time).