Skip to content

update QScintilla easyblock to be compatible with PyQt5 >= 5.15#2845

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
akesandgren:20221213150252_new_pr_qscintilla
Dec 14, 2022
Merged

update QScintilla easyblock to be compatible with PyQt5 >= 5.15#2845
jfgrimm merged 1 commit intoeasybuilders:developfrom
akesandgren:20221213150252_new_pr_qscintilla

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@akesandgren
Copy link
Copy Markdown
Contributor Author

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • SUCCESS QScintilla-2.11.6-GCCcore-11.2.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/c67cc6900cf1ce9fc420ee5d7795e4c1 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Dec 14, 2022

Test report by @jfgrimm

Overview of tested easyconfigs (in order)

Build succeeded for 7 out of 9 (2 easyconfigs in total)
himem03.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/a478edf627414f7cdac8ea9d2a55491b for a full test

nb PyQt5 w/ GCCcore 8.2.0 failed due to sip source no longer being available

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Dec 14, 2022

Going in, thanks @akesandgren!

@jfgrimm jfgrimm merged commit ba2f204 into easybuilders:develop Dec 14, 2022
@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.7.0) Dec 14, 2022
@akesandgren akesandgren deleted the 20221213150252_new_pr_qscintilla branch December 15, 2022 05:50
@boegel boegel changed the title update qscintilla.py to be compatible with EB install of PyQt5 >= 5.15 update QScintilla easyblock to be compatible with PyQt5 >= 5.15 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants