maintain backward compatibility in R easyblock by hard linking with $LIBBLAS (for now)#1300
Merged
wpoely86 merged 1 commit intoeasybuilders:developfrom Nov 28, 2017
Merged
Conversation
…LIBBLAS (for now)
wpoely86
approved these changes
Nov 28, 2017
This was referenced Dec 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded use of
$LIBBLASwas replaced with using$LIBBLAS_MTinstead in #1292, which is a backward incompatible change.The idea is to allow tweaking this via a new toolchain option
mt_blas_lapack(or equivalent approach), see discussion in easybuilders/easybuild-framework#2350.(see also #202)
Until that is in place, we should stick to using
$LIBBLASto maintain backward compatibility.