Skip to content

Cleanup old files and an old dependency#486

Merged
lwasser merged 2 commits intomainfrom
cleanup
Feb 10, 2022
Merged

Cleanup old files and an old dependency#486
lwasser merged 2 commits intomainfrom
cleanup

Conversation

@lwasser
Copy link
Copy Markdown

@lwasser lwasser commented Feb 3, 2022

closes #415
This is a small PR to clean up some lingering elements of files and dependencies that were needed in the initial version of abcclassroom.

We should consider another release after all of the PR's we discussed today in our maintenance meeting are addressed.
This probably won't pass CI until we merge #485 to fix the docs build.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2022

Codecov Report

Merging #486 (e21308c) into main (abadd66) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files          20       20           
  Lines        1169     1169           
=======================================
  Hits          707      707           
  Misses        462      462           
Flag Coverage Δ
unittests 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abadd66...e21308c. Read the comment docs.

@lwasser
Copy link
Copy Markdown
Author

lwasser commented Feb 10, 2022

merging this!

@lwasser lwasser merged commit 3de0d2d into main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What dependencies does abc-classroom need

1 participant