Skip to content

update doc build to python 3.8 only & add python 3.9 to build#485

Merged
lwasser merged 6 commits intomainfrom
update-docs-build
Feb 10, 2022
Merged

update doc build to python 3.8 only & add python 3.9 to build#485
lwasser merged 6 commits intomainfrom
update-docs-build

Conversation

@lwasser
Copy link
Copy Markdown

@lwasser lwasser commented Feb 3, 2022

This closes #481
The issue here is that the pydata sphinx theme doesn't support python 3.6 which is end of life.
We probably want to remove support for 3.6 at this point and add support for 3.9 but we may not have time to do this as we have to wrap up maintenance of this package for the time being.

For now we are simply removing the build of the docs to allow for other PR's to successfully build. But in the longer term someone will need to go in here and decide to remove python 3.6 from support.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2022

Codecov Report

Merging #485 (57bce21) into main (941592f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files          20       20           
  Lines        1169     1169           
=======================================
  Hits          707      707           
  Misses        462      462           
Flag Coverage Δ
unittests 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941592f...57bce21. Read the comment docs.

@lwasser
Copy link
Copy Markdown
Author

lwasser commented Feb 3, 2022

@kcranston @nkorinek this is the fix - i just made the build ONLY build on python 3.8. should we consider adding a build for 3.9 ? just lemme know what you think but this could be merged as is too. it's a simply fix .

@lwasser lwasser changed the title update doc build to python 3.8 only update doc build to python 3.8 only & add python 3.9 to build Feb 10, 2022
@lwasser lwasser merged commit 7e4e4af into main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we want to keep python 3.6 support & docs build

1 participant