update doc build to python 3.8 only & add python 3.9 to build#485
Merged
update doc build to python 3.8 only & add python 3.9 to build#485
Conversation
Codecov Report
@@ Coverage Diff @@
## main #485 +/- ##
=======================================
Coverage 60.47% 60.47%
=======================================
Files 20 20
Lines 1169 1169
=======================================
Hits 707 707
Misses 462 462
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Author
|
@kcranston @nkorinek this is the fix - i just made the build ONLY build on python 3.8. should we consider adding a build for 3.9 ? just lemme know what you think but this could be merged as is too. it's a simply fix . |
This was referenced Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #481
The issue here is that the pydata sphinx theme doesn't support python 3.6 which is end of life.
We probably want to remove support for 3.6 at this point and add support for 3.9 but we may not have time to do this as we have to wrap up maintenance of this package for the time being.
For now we are simply removing the build of the docs to allow for other PR's to successfully build. But in the longer term someone will need to go in here and decide to remove python 3.6 from support.