Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ValidatorHandler; ErrorKind; URL #63

Merged
merged 27 commits into from
Jan 24, 2023
Merged

Add ValidatorHandler; ErrorKind; URL #63

merged 27 commits into from
Jan 24, 2023

Conversation

earthboundkid
Copy link
Owner

This is a different take on #54. Instead of adding OnError, it creates fused ValidationHandlers and add ErrorJSON. See discussions in #52 and #32.

@earthboundkid
WIP Add OnError (still needs docs, tests)
78560a7
@earthboundkid
Add ErrorKind tests, tweak names
a0c528c
@earthboundkid
Fix race
f4b5d8d
@earthboundkid
Naming consistency
4abc279
@earthboundkid
Rename to OnValidatorError
8f9c113
@earthboundkid
Change ErrorHandler signature
51a747c
@earthboundkid
Remove HasKindErr because it's redundant now
27a1cc4
@earthboundkid
Run error handlers in reverse order
710e700
@earthboundkid
ValidatorHandler should wrap the error kind
5cb0a52
@earthboundkid
ExampleBuilder_OnError: show error wrapping ability
8e5a5fb
@earthboundkid
Add OnErrorParams type and Builder.URL()
e0431c2
@earthboundkid
ErrorKind: Make errors.Is testable
5161466
@earthboundkid
Add OnErrorParams.Context()
b9d2493
@earthboundkid
Docs: Note that ep.Kind is immutable
8606a18
@earthboundkid
ErrorKind: Add errors.As support
4664414
@earthboundkid
ErrorKind: Simplify .Is checking
52275eb
@earthboundkid
ErrorKind: Names for parameters
c143030
@earthboundkid
builder_core: Remove extra wrapper around URL error
fbc516a
@earthboundkid
Use ValidatorHandlers instead of ErrorHandlers
7f4b6f8
@earthboundkid
Require Go 1.20 for multierrors
0004467
@earthboundkid earthboundkid changed the title Add ValidatorHandler Add ValidatorHandler; ErrorKind; URL Jan 20, 2023
@earthboundkid
Copy link
Owner Author

earthboundkid commented Jan 20, 2023 •
edited
Loading

  • Add an example of ErrorJSON that uses string responses.

@earthboundkid earthboundkid force-pushed the cj/validator-handler branch 4 times, most recently from 35339cf to 843dd0c Compare January 20, 2023 15:30
@earthboundkid
Docs: Rewrite Builder doc
4897915 
Use headings and semantic line breaks
@earthboundkid
Copy link
Owner Author

This is blocked until Go 1.20 comes out. But I think it's otherwise done.

@earthboundkid earthboundkid merged commit e883801 into main Jan 24, 2023
@earthboundkid earthboundkid deleted the cj/validator-handler branch January 24, 2023 21:38
@earthboundkid earthboundkid mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@earthboundkid