Add OnError #54
Closed
Add OnError #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earthboundkid
commented
Sep 25, 2022
earthboundkid
commented
Sep 25, 2022
earthboundkid
commented
Sep 25, 2022
earthboundkid
commented
Sep 25, 2022
earthboundkid
force-pushed
the
exp/onerror
branch
3 times, most recently
from
5ab9bc5
to
d934fe9
Compare
|
Can I help on moving forward with this PR? I'm very interested on start using it. Thanks |
|
See the discussion in #52. I’m still not convinced the API is right. I can issue an alpha version with an unstable API though if you don’t mind being broken if it changes again. |
|
I released an alpha version. |
earthboundkid
commented
Oct 31, 2022
earthboundkid
commented
Oct 31, 2022
| @@ -174,3 +174,9 @@ func (rb *Builder) ToHeaders(h map[string][]string) *Builder { | |||
| Head(). | |||
| Handle(ChainHandlers(CopyHeaders(h), consumeBody)) | |||
| } | |||
|
|
|||
| // OnValidatorError calls OnError by converting h with ValidatorHandler into an ErrorHandler. | |||
earthboundkid
commented
Oct 31, 2022
|
Thanks, we will give it a try and provide feedback.
…On Mon, Oct 31, 2022, 15:18 Carl Johnson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In builder_core.go
<#54 (comment)>:
> @@ -165,6 +166,12 @@ func (rb *Builder) Config(cfgs ...Config) *Builder {
return rb
}
+// OnError adds an ErrorHandler to run if any part of building, validating, or handling a request fails.
Add more documentation.
—
Reply to this email directly, view it on GitHub
<#54 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACVLXBJFBKP6JUI2GIENTWF7ILVANCNFSM6AAAAAAQVGMAFE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
earthboundkid
force-pushed
the
exp/onerror
branch
from
badeabb
to
4eb2ea5
Compare
earthboundkid
force-pushed
the
exp/onerror
branch
from
4eb2ea5
to
a05f88c
Compare
earthboundkid
force-pushed
the
exp/onerror
branch
from
a85671b
to
ec4028b
Compare
earthboundkid
force-pushed
the
exp/onerror
branch
from
ec4028b
to
2bbf480
Compare
|
See #63, which has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #52 and #32.