Skip to content

feature/single precision#171

Closed
climbfuji wants to merge 1 commit into
earth-system-radiation:dtc/ccppfrom
climbfuji:feature/single_precision
Closed

feature/single precision#171
climbfuji wants to merge 1 commit into
earth-system-radiation:dtc/ccppfrom
climbfuji:feature/single_precision

Conversation

@climbfuji
Copy link
Copy Markdown
Contributor

WORK IN PROGRESS

  • Switch working precision to single precision of preprocessor flag -DSINGLE_PRECISION is set

@RobertPincus
Copy link
Copy Markdown
Member

RobertPincus commented May 22, 2022

@climbfuji Note the same functionality is already on the develop branch in commit 345aefb.

I like to move things from develop to main and then out to autoconf and ccpp. If this is pressing please let me know and I'll update main.

Note also that this won't work - some calculations will fail if done in single precision. This is something we're working on and can prioritize if you have an immediate need.

@climbfuji
Copy link
Copy Markdown
Contributor Author

climbfuji commented May 22, 2022

@climbfuji Note the same functionality is already on the develop branch in commit 345aefb.

I like to move things from develop to main and then out to autoconf and ccpp. If this is pressing please let me know and I'll update main.

Note also that this won't work - some calculations will fail if done in single precision. This is something we're working on and can prioritize if you have an immediate need.

@RobertPincus Absolutely agree. You'll be receiving an email in a second that provides more background.

@Chiil
Copy link
Copy Markdown
Collaborator

Chiil commented May 22, 2022

Would it be a good idea to add a prefix RTE_RRTMGP_ or something similar to preprocessor flags?

@RobertPincus
Copy link
Copy Markdown
Member

Closed with a4fe30c but note that code compiled as single precision almost certainly won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants