feature/single precision (ESMF init errors)#2
Closed
climbfuji wants to merge 2 commits into
Closed
Conversation
Author
|
This PR is no longer needed, these errors have been fixed (much better than what I had suggested). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
Note. The current code in @SamuelTrahanNOAA's branches (recursive clone of branch
sing_prec_from_mainof the ufs-weather-model, see PR ufs-community/ufs-weather-model#1215) crashes in the model initialization step, but not in the physics - it crashes deep inside the ESMF grid/field initialization (cont'd below):This PR is a fool's attempt from someone with no idea of ESMF and how the coupling is realized to make this work. But it doesn't, still the same error. I actually believe that it would be better to improve the interface between the physics fields and the coupling fields, so that: