Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add board Seeed Indicator RP2040 #1375

Merged
merged 7 commits into from
Apr 21, 2023

Conversation

Wvirgil123
Copy link
Contributor

No description provided.

Wvirgil123 and others added 4 commits April 13, 2023 19:07
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new board, but I do have a minor request.

Can you please fix the alphabetization? This should go before the XIAO in the menus, make boards, etc.

fix the alphabetization
@Wvirgil123
Copy link
Contributor Author

Thanks for the new board, but I do have a minor request.

Can you please fix the alphabetization? This should go before the XIAO in the menus, make boards, etc.

ok

@earlephilhower
Copy link
Owner

You'll need to add the modified boards.txt file, as well. Otherwise I think is looking good.

@Wvirgil123
Copy link
Contributor Author

You'll need to add the modified boards.txt file, as well. Otherwise I think is looking good.

Because I noticed that it says don't edit the file(boards.txt).

# WARNING - DO NOT EDIT THIS FILE, IT IS MACHINE GENERATED

@earlephilhower
Copy link
Owner

earlephilhower commented Apr 21, 2023

Don't manually edit the file, just run the make boards script and check that updated boards.txt in and it should be okay.

Edit.... Phone autocorrect can do weird things!

@Wvirgil123
Copy link
Contributor Author

Don't manually edit the file, just run the make boards script and check that updated boards.txt in and it should be okay.

Edit.... Phone autocorrect can do weird things!

ok, I misunderstood. I thought it was CI automatically compiled and added. boards.txt has been updated.

@earlephilhower earlephilhower merged commit 0322a68 into earlephilhower:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants