Skip to content

Changed esp32 OTA upload command #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
earlephilhower merged 3 commits into from
Mar 4, 2025
Merged

Changed esp32 OTA upload command #85

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e280775
Changed esp32 OTA upload command to use "espota" instead of "espota.p…
Mar 4, 2025
f3797fc
Changed OTA upload under macOS to use python script.
Mar 4, 2025
9e00192
Updated comments in code to reflect previous changes.
Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,18 +500,18 @@ export function activate(context: vscode.ExtensionContext) {
}
} else if (esp32) {
if (network) {
let espota = "tools" + path.sep + "espota.py";
let espota = "tools" + path.sep + "espota";
let espotaPath = findTool(arduinoContext, "runtime.platform.path");
if (espotaPath) {
espota = espotaPath + path.sep + espota;
}
uploadOpts = ["-r", "-i", serialPort, "-p", String(networkPort), "-f", imageFile, "-s"];

if ((platform() === 'win32') || (platform() === 'darwin')) {
cmdApp = espota; // Have binary EXE on Mac/Windows
if (platform() === 'win32') {
cmdApp = espota; // Have binary EXE on Windows
} else {
cmdApp = "python3"; // Not shipped, assumed installed on Linux
uploadOpts.unshift(espota); // Need to call Python3
cmdApp = "python3"; // Not shipped, assumed installed on Linux and MacOS
uploadOpts.unshift(espota + ".py"); // Need to call Python3
Comment thread
earlephilhower marked this conversation as resolved.
}
} else {
let flashMode = arduinoContext.boardDetails.buildProperties["build.flash_mode"];
Expand Down