Changed esp32 OTA upload command#85
Merged
Merged
Conversation
…y" under windows and macOS.
earlephilhower
requested changes
Mar 4, 2025
Owner
|
Just did a quick sanity on the PicoW and it's all good. Thx again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed esp32 OTA upload command to use "espota" instead of "espota.py" under windows and macOS.
currently under Windows the upload uses espota.py (not "python espota.py") as upload command, which is invalid. On windows there is espota.exe for upload. The code change causes the upload command to be "espota" rather than "espota.py", so the executable is called.
Note: While I could verify that this fixes the problem under Windows, I could not test the change under Linux and macOS. While the change is simple enough that I don't think the current Linux behaviour should be affected, I'm not sure about macOS as I don't know whether it comes with an executable binary named "espota".