Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newline-eof compiler warning #347

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix newline-eof compiler warning #347

merged 1 commit into from
Mar 3, 2023

Conversation

srmainwaring
Copy link
Contributor

Add EOF newline to session.c.

Resolves build warning:

[ 23%] Building C object CMakeFiles/microxrcedds_client.dir/src/c/core/session/session.c.o
/Users/rhys/Code/ros2/xrce-dds/eprosima/eprosima_ws/src/microxrcedds_client/src/c/core/session/session.c:1272:2: warning: no newline at end of file [-Wnewline-eof]
}
 ^
1 warning generated.

@srmainwaring
Fix newline-eof compiler warning
8b0c3d6 
Add EOF newline to session.c.

Signed-off-by: Rhys Mainwaring <[email protected]>
@Acuadros95 Acuadros95 merged commit bc6e9c3 into eProsima:develop Mar 3, 2023
Acuadros95 added a commit that referenced this pull request Mar 29, 2023
@Acuadros95 @srmainwaring
@pablogs9 @mergify
Merge pull request #354 from eProsima/develop
747671f 
* Add CMAKE configuration for C standard version (#340)

* Add C standard configuration

Signed-off-by: acuadros95 <[email protected]>

* Update C define

Signed-off-by: acuadros95 <[email protected]>

* Remove CMAKE conditional

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>

* Fix build for macOS (#346)

* Add Twitter and Readthedocs shields (#307) (#308)

* Add Twitter and Readthedocs shields

Signed-off-by: Pablo Garrido <[email protected]>

* Update

Signed-off-by: Pablo Garrido <[email protected]>

* Fix

Signed-off-by: Pablo Garrido <[email protected]>
(cherry picked from commit 8b78d22)

Co-authored-by: Pablo Garrido <[email protected]>

* Fix build for macOS

- Add check for CMAKE_SYSTEM_NAME "Darwin".

Signed-off-by: Rhys Mainwaring <[email protected]>

---------

Signed-off-by: Rhys Mainwaring <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Fix newline-eof compiler warning (#347)

Add EOF newline to session.c.

Signed-off-by: Rhys Mainwaring <[email protected]>

* Fix doxygen warning (#352)

* Remove outdated navindex tag

Signed-off-by: acuadros95 <[email protected]>

* Revert unwanted removal

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>

* Add missing doxygen parameter (#353)

Signed-off-by: acuadros95 <[email protected]>

* Fix domain id argument in create_participant API (#348)

---------

Signed-off-by: acuadros95 <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
Co-authored-by: Rhys Mainwaring <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
pablogs9 added a commit that referenced this pull request Mar 29, 2023
@Acuadros95 @srmainwaring
@pablogs9 @mergify
Release v2.4.0
a2937bc 
* Add CMAKE configuration for C standard version (#340)

* Add C standard configuration

Signed-off-by: acuadros95 <[email protected]>

* Update C define

Signed-off-by: acuadros95 <[email protected]>

* Remove CMAKE conditional

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>

* Fix build for macOS (#346)

* Add Twitter and Readthedocs shields (#307) (#308)

* Add Twitter and Readthedocs shields

Signed-off-by: Pablo Garrido <[email protected]>

* Update

Signed-off-by: Pablo Garrido <[email protected]>

* Fix

Signed-off-by: Pablo Garrido <[email protected]>
(cherry picked from commit 8b78d22)

Co-authored-by: Pablo Garrido <[email protected]>

* Fix build for macOS

- Add check for CMAKE_SYSTEM_NAME "Darwin".

Signed-off-by: Rhys Mainwaring <[email protected]>

---------

Signed-off-by: Rhys Mainwaring <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Fix newline-eof compiler warning (#347)

Add EOF newline to session.c.

Signed-off-by: Rhys Mainwaring <[email protected]>

* Fix doxygen warning (#352)

* Remove outdated navindex tag

Signed-off-by: acuadros95 <[email protected]>

* Revert unwanted removal

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>

* Add missing doxygen parameter (#353)

Signed-off-by: acuadros95 <[email protected]>

* Fix domain id argument in create_participant API (#348)

---------

Signed-off-by: acuadros95 <[email protected]>
Signed-off-by: Rhys Mainwaring <[email protected]>
Co-authored-by: Rhys Mainwaring <[email protected]>
Co-authored-by: Pablo Garrido <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

@Acuadros95 Acuadros95 Acuadros95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srmainwaring @pablogs9 @Acuadros95