Fix build for macOS #346
Merged
Fix build for macOS #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Twitter and Readthedocs shields Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 8b78d22) Co-authored-by: Pablo Garrido <[email protected]>
- Add check for CMAKE_SYSTEM_NAME "Darwin". Signed-off-by: Rhys Mainwaring <[email protected]>
|
Build status:
|
Not sure if you wish to support macOS, but if so I'm happy to help. There is some interest in the ArduPilot community of enabling micro-ros / xrce-dds and ideally we would have multi-platform support for simulation. |
pablogs9
approved these changes
Mar 2, 2023
Acuadros95
approved these changes
Mar 2, 2023
Acuadros95
added a commit
that referenced
this pull request
Mar 29, 2023
* Add CMAKE configuration for C standard version (#340) * Add C standard configuration Signed-off-by: acuadros95 <[email protected]> * Update C define Signed-off-by: acuadros95 <[email protected]> * Remove CMAKE conditional Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: acuadros95 <[email protected]> * Fix build for macOS (#346) * Add Twitter and Readthedocs shields (#307) (#308) * Add Twitter and Readthedocs shields Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 8b78d22) Co-authored-by: Pablo Garrido <[email protected]> * Fix build for macOS - Add check for CMAKE_SYSTEM_NAME "Darwin". Signed-off-by: Rhys Mainwaring <[email protected]> --------- Signed-off-by: Rhys Mainwaring <[email protected]> Co-authored-by: Pablo Garrido <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fix newline-eof compiler warning (#347) Add EOF newline to session.c. Signed-off-by: Rhys Mainwaring <[email protected]> * Fix doxygen warning (#352) * Remove outdated navindex tag Signed-off-by: acuadros95 <[email protected]> * Revert unwanted removal Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: acuadros95 <[email protected]> * Add missing doxygen parameter (#353) Signed-off-by: acuadros95 <[email protected]> * Fix domain id argument in create_participant API (#348) --------- Signed-off-by: acuadros95 <[email protected]> Signed-off-by: Rhys Mainwaring <[email protected]> Co-authored-by: Rhys Mainwaring <[email protected]> Co-authored-by: Pablo Garrido <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
pablogs9
added a commit
that referenced
this pull request
Mar 29, 2023
* Add CMAKE configuration for C standard version (#340) * Add C standard configuration Signed-off-by: acuadros95 <[email protected]> * Update C define Signed-off-by: acuadros95 <[email protected]> * Remove CMAKE conditional Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: acuadros95 <[email protected]> * Fix build for macOS (#346) * Add Twitter and Readthedocs shields (#307) (#308) * Add Twitter and Readthedocs shields Signed-off-by: Pablo Garrido <[email protected]> * Update Signed-off-by: Pablo Garrido <[email protected]> * Fix Signed-off-by: Pablo Garrido <[email protected]> (cherry picked from commit 8b78d22) Co-authored-by: Pablo Garrido <[email protected]> * Fix build for macOS - Add check for CMAKE_SYSTEM_NAME "Darwin". Signed-off-by: Rhys Mainwaring <[email protected]> --------- Signed-off-by: Rhys Mainwaring <[email protected]> Co-authored-by: Pablo Garrido <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fix newline-eof compiler warning (#347) Add EOF newline to session.c. Signed-off-by: Rhys Mainwaring <[email protected]> * Fix doxygen warning (#352) * Remove outdated navindex tag Signed-off-by: acuadros95 <[email protected]> * Revert unwanted removal Signed-off-by: acuadros95 <[email protected]> --------- Signed-off-by: acuadros95 <[email protected]> * Add missing doxygen parameter (#353) Signed-off-by: acuadros95 <[email protected]> * Fix domain id argument in create_participant API (#348) --------- Signed-off-by: acuadros95 <[email protected]> Signed-off-by: Rhys Mainwaring <[email protected]> Co-authored-by: Rhys Mainwaring <[email protected]> Co-authored-by: Pablo Garrido <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix to enable compilation on macOS.
Update CMakeLists.txt to check for
CMAKE_SYSTEM_NAME"Darwin" and setUCLIENT_PLATFORM_POSIX=ONif true.System: macOS Monterey, version 12.6.2 (Intel)
Xcode: 14.2 (14C18).