Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21768] DDS data publication implementation #2

Closed
wants to merge 21 commits into from

Conversation

juanlofer-eprosima
Copy link

@juanlofer-eprosima juanlofer-eprosima commented Jan 9, 2025

Merge after:

This branch is also on top of feature/json_config, probably should create a dedicated PR adding that capability.

adriancampo and others added 20 commits October 3, 2024 12:06
Signed-off-by: adriancampo <[email protected]>
Signed-off-by: adriancampo <[email protected]>
Signed-off-by: adriancampo <[email protected]>
Signed-off-by: adriancampo <[email protected]>
Signed-off-by: adriancampo <[email protected]>
Signed-off-by: adriancampo <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@juanlofer-eprosima juanlofer-eprosima changed the title DDS data publication implementation [21768] DDS data publication implementation Jan 9, 2025
@EugenioCollado EugenioCollado self-requested a review January 10, 2025 10:59
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@@ -87,6 +104,11 @@ class DDSEnabler
utils::ReturnCode reload_configuration(
yaml::EnablerConfiguration& new_configuration);

// TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@@ -50,6 +50,8 @@ This callback is invoked by the ``CBHandler`` through the ``CBWriter`` class.
const char* topicName,
const char* serializedType);

.. TODO: update with topic notification, topic request and type request callbacks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@juanlofer-eprosima
Copy link
Author

Closed in favor of #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants