fix: Phase 2 — backport 5 high-priority upstream bug fixes#27
Merged
Conversation
Cherry-picked: - 0d7e62a53 (#17815, Kit Langton): Fix forked prompt attachments losing file parts — new part.ts with strip/assign helpers Reimplemented: - cc818f803 (#18283, Protocol Zero): Only set thinkingConfig for models with reasoning capability — prevents errors on non-reasoning Google models - d69962b0f (#18264, James Long): Disable chunk timeout by default — prevents false timeouts on slow providers - 84e62fc66 (#18165, Kit Langton): Preserve tagged error messages — use e.message instead of e.toString() in fromError() - 054075189 (#18259, James Long): Queue-based event route processing — prevents backpressure when events arrive faster than SSE can flush Already applied (skipped): - SIGHUP handler — already in our tree - Truncate permission cycle — already fixed by our Effect-based refactor - Ariane timeout fix — not found in upstream 1488 tests passing, 0 tsgo errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2: High-Priority Upstream Bug Fixes
Backported 5 fixes from vouched upstream contributors. 1 cherry-picked cleanly, 4 manually reimplemented due to architectural divergence.
Cherry-picked
Fix forked prompt attachments losing file parts
@kitlangton)0d7e62a53part.tswithstrip()/assign()helpers for prompt part handlingReimplemented
Only set thinkingConfig for models with reasoning capability
@Protocol-zero-0)cc818f803thinkingConfigwithif (input.model.capabilities.reasoning)checkDisable chunk timeout by default
@jlongster)d69962b0fDEFAULT_CHUNK_TIMEOUTconstant; timeout nowundefinedby defaultPreserve tagged error messages
@kitlangton)84e62fc66e.toString()→e.messageinfromError()to preserve tagged error infoQueue-based event route processing
@jlongster)054075189Already applied / not applicable
Test plan
bun run typecheck(tsgo) — 0 errorsbun test— 1488 pass, 0 fail (2 new from cherry-picked prompt-part tests)