Skip to content

fix(session): preserve tagged error messages#18165

Merged
kitlangton merged 1 commit intodevfrom
fix/question-rejected-error-text
Mar 19, 2026
Merged

fix(session): preserve tagged error messages#18165
kitlangton merged 1 commit intodevfrom
fix/question-rejected-error-text

Conversation

@kitlangton
Copy link
Contributor

Summary

  • store Error.message instead of toString() for tool errors so Effect tagged errors stay human-readable
  • apply the same formatting in MessageV2.fromError to avoid leaking structural tagged error strings through the unknown-error path
  • add a regression test covering Question.RejectedError serialization

Testing

  • bun run test test/session/message-v2.test.ts test/question/question.test.ts
  • bun run typecheck

@kitlangton kitlangton force-pushed the fix/question-rejected-error-text branch from cedab54 to c753e1b Compare March 19, 2026 00:35
@kitlangton kitlangton merged commit 84e62fc into dev Mar 19, 2026
6 checks passed
@kitlangton kitlangton deleted the fix/question-rejected-error-text branch March 19, 2026 00:36
AvatarGanymede pushed a commit to AvatarGanymede/opencode-dev that referenced this pull request Mar 19, 2026
demostanis pushed a commit to demostanis/opencode that referenced this pull request Mar 19, 2026
filipeandre pushed a commit to filipeandre/opencode that referenced this pull request Mar 19, 2026
raf1hh pushed a commit to raf1hh/opencode that referenced this pull request Mar 20, 2026
pengzha0 pushed a commit to pengzha0/dwtcode that referenced this pull request Mar 20, 2026
demostanis pushed a commit to demostanis/opencode that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant