Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize user list sync bandwidth and performance #902

Merged
merged 8 commits into from
Jun 9, 2023
Merged

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Jun 8, 2023

  • refactor how the user list is synced to save bandwidth
  • fix you server message not being handled
  • update log to be more severe
  • make users store namespaced
  • make sure grants get synced
  • fix lints
  • update component tests
  • fix some e2e tests

closes #882

@cypress
Copy link

cypress bot commented Jun 8, 2023

Passing run #235 ↗︎

0 68 0 1 Flakiness 0

Details:

Merge 8ef3103 into f8e1da4...
Project: OpenTogetherTube Commit: 60e0a94ab4 ℹ️
Status: Passed Duration: 03:29 💡
Started: Jun 8, 2023 5:29 PM Ended: Jun 8, 2023 5:33 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #902 (8ef3103) into master (f8e1da4) will decrease coverage by 0.1198%.
The diff coverage is 35.0000%.

@@               Coverage Diff                @@
##             master       #902        +/-   ##
================================================
- Coverage   60.2265%   60.1068%   -0.1198%     
================================================
  Files            89         89                
  Lines          9886       9919        +33     
  Branches        952        947         -5     
================================================
+ Hits           5954       5962         +8     
- Misses         3932       3957        +25     
Impacted Files Coverage Δ
client/src/components/ServerMessageHandler.vue 33.3333% <0.0000%> (-2.3810%) ⬇️
client/src/plugins/connection.ts 37.9085% <0.0000%> (ø)
client/src/store.ts 100.0000% <ø> (ø)
server/room.ts 51.9148% <10.0000%> (-0.2900%) ⬇️
server/clientmanager.ts 24.3801% <37.5000%> (+0.9674%) ⬆️
client/src/stores/users.ts 44.6808% <38.0000%> (-13.2139%) ⬇️
client/src/components/RoomSettingsForm.vue 54.6762% <66.6666%> (-0.1974%) ⬇️
client/src/util/grants.ts 85.7142% <66.6666%> (ø)
client/src/views/Room.vue 50.7497% <100.0000%> (ø)

@dyc3 dyc3 changed the title Optimize user list sync bandwidth and server performance Optimize user list sync bandwidth and performance Jun 9, 2023
@dyc3 dyc3 merged commit 77a5cf8 into master Jun 9, 2023
@dyc3 dyc3 deleted the move-isyou branch June 9, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move isYou assertion to the client side.
1 participant