Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users not removed from user list when disconnected. #630

Open
2 of 3 tasks
dyc3 opened this issue Feb 14, 2022 · 2 comments
Open
2 of 3 tasks

Users not removed from user list when disconnected. #630

dyc3 opened this issue Feb 14, 2022 · 2 comments
Labels
bug Something isn't working regression An intentional behavior that worked before does not work now server Improvements or additions to the server sync Issues pertaining to video synchronization ui-ux/user Problem with the UI/UX from an end user perspective
Milestone
Better User Manag...

Comments

@dyc3
Copy link
Owner

dyc3 commented Feb 14, 2022

Current Behavior

Under some weird edge case scenarios, it's possible that when a client disconnects, the user is not removed from the user list.

When this occurs, the user remains present in the room state, but is no longer present in the client manager.

Expected Behavior

When a user leaves a room, they should be removed from the list.

Steps To Reproduce

Precise steps unknown.

Environment

  • This happens on the official site, opentogethertube.com
  • This happens using a self-hosted version.
  • I'm using the docker image.

Anything else?

No response
@dyc3 dyc3 added bug Something isn't working server Improvements or additions to the server regression An intentional behavior that worked before does not work now sync Issues pertaining to video synchronization labels Feb 14, 2022
@dyc3
Copy link
Owner Author

dyc3 commented Nov 30, 2022

I've added the ott_users_in_rooms and ott_websocket_connections metrics to start to track this better.

@dyc3 dyc3 added the ui-ux/user Problem with the UI/UX from an end user perspective label Jun 9, 2023
@dyc3 dyc3 added this to the Better User Management milestone Jun 9, 2023
@dyc3
Copy link
Owner Author

dyc3 commented Jun 9, 2023

This may be fixed by #902. Leaving open for now until I'm confident it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression An intentional behavior that worked before does not work now server Improvements or additions to the server sync Issues pertaining to video synchronization ui-ux/user Problem with the UI/UX from an end user perspective
Projects
None yet
Milestone
Better User Management
Development

No branches or pull requests
1 participant
@dyc3