Skip to content

client: refactor volume controls into a composable for simplicity #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024

refactor volume controls into a composable

a12fb9c
Select commit
Loading
Failed to load commit list.
Merged

client: refactor volume controls into a composable for simplicity #1561

refactor volume controls into a composable
a12fb9c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 25, 2024 in 1s

56.3117% (target 50.0000%)

View this Pull Request on Codecov

56.3117% (target 50.0000%)

Details

Codecov Report

Attention: Patch coverage is 27.50000% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 56.3117%. Comparing base (dd9dc30) to head (a12fb9c).

Files Patch % Lines
client/src/components/players/OmniPlayer.vue 6.6666% 14 Missing ⚠️
client/src/components/composables/media-player.ts 33.3333% 12 Missing ⚠️
client/src/components/controls/VolumeControl.vue 50.0000% 2 Missing ⚠️
client/src/views/Room.vue 50.0000% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1561        +/-   ##
================================================
+ Coverage   56.2985%   56.3117%   +0.0132%     
================================================
  Files           164        164                
  Lines         24990      24993         +3     
  Branches       1440       1440                
================================================
+ Hits          14069      14074         +5     
+ Misses        10867      10865         -2     
  Partials         54         54                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.