New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: refactor volume controls into a composable for simplicity #1561

Merged

dyc3 merged 1 commit into master from use-volume

Mar 25, 2024

Merged

client: refactor volume controls into a composable for simplicity #1561

refactor volume controls into a composable

Codecov / codecov/patch failed Mar 25, 2024 in 0s

27.5000% of diff hit (target 60.0000%)

View this Pull Request on Codecov

27.5000% of diff hit (target 60.0000%)

Annotations

Check warning on line 18 in client/src/components/composables/media-player.ts

codecov / codecov/patch

client/src/components/composables/media-player.ts#L7-L18

Added lines #L7 - L18 were not covered by tests

Check warning on line 34 in client/src/components/controls/VolumeControl.vue

codecov / codecov/patch

client/src/components/controls/VolumeControl.vue#L34

Added line #L34 was not covered by tests

Check warning on line 38 in client/src/components/controls/VolumeControl.vue

codecov / codecov/patch

client/src/components/controls/VolumeControl.vue#L38

Added line #L38 was not covered by tests

Check warning on line 343 in client/src/components/players/OmniPlayer.vue

codecov / codecov/patch

client/src/components/players/OmniPlayer.vue#L331-L343

Added lines #L331 - L343 were not covered by tests

Check warning on line 346 in client/src/components/players/OmniPlayer.vue

codecov / codecov/patch

client/src/components/players/OmniPlayer.vue#L346

Added line #L346 was not covered by tests

Check warning on line 435 in client/src/views/Room.vue

codecov / codecov/patch

client/src/views/Room.vue#L435

Added line #L435 was not covered by tests

View more details on Codecov