-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch ott-server
to use proper ott-common
imports
#1378
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Passing run #1082 ↗︎
Details:
Review all test suite changes for PR #1378 ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1378 +/- ##
================================================
+ Coverage 54.0566% 54.1663% +0.1096%
================================================
Files 159 158 -1
Lines 24700 24650 -50
Branches 1445 1437 -8
================================================
Hits 13352 13352
+ Misses 11290 11241 -49
+ Partials 58 57 -1 ☔ View full report in Codecov by Sentry. |
… relative file path (#1356) * switch `ott-server` to import `ott-common` instead of referencing the relative file path * fix lints * Revert "fix lints" This reverts commit 1da6370. * fix auth middleware to not allow undefined tokens to be valid, fixes new type errors * fix missing await * fix lints and format
da4145c
to
0575d03
Compare
Passing run #1083 ↗︎
Details:
Review all test suite changes for PR #1378 ↗︎ |
ott-server
to importott-common
instead of referencing the relative file path (bringing back switchott-server
to importott-common
instead of referencing the relative file path #1356)closes #1375