client: Spanish Localization #1263

Victor-M-Giraldo · 2024-01-23T21:40:43Z

Pull requests adds localization in Spanish to OTT.

coderabbitai · 2024-01-23T21:40:48Z

Walkthrough

The recent update introduces a Spanish language option to the application's navigation bar, allowing users to select Spanish as their interface language. This enhancement is accompanied by the necessary Spanish translations for the user interface, ensuring a seamless user experience for Spanish-speaking users.

Changes

File Path	Change Summary
`client/src/components/navbar/LocaleSelector.vue`	Added Spanish language option with flag "🇪🇸" and value "es".
`client/src/locales/es.ts`	Introduced Spanish translations for various user interface elements.

Poem

🐇💻🌟

In the code, a hop, a skip, a leap,
A language blooms, no hill too steep.
🇪🇸 A flag unfurls, the screen to grace,
En español, our app's new face. 🌐✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d7c7eec and 1ee7564.

Files selected for processing (2)

client/src/components/navbar/LocaleSelector.vue (1 hunks)
client/src/locales/sp.ts (1 hunks)

Additional comments: 2

client/src/components/navbar/LocaleSelector.vue (1)

33-36: Added a new language option for Spanish with the flag "🇪🇸" and the value "sp" to the list of locales in the LocaleSelector component.

client/src/locales/sp.ts (1)

1-378: The Spanish localization file sp.ts has been added, containing translations for various UI elements and messages.

codecov · 2024-01-23T21:45:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34beeaf) 61.5425% compared to head (eb3ecd1) 61.5711%.
Report is 6 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1263        +/-   ##
================================================
+ Coverage   61.5425%   61.5711%   +0.0285%     
================================================
  Files           117        117                
  Lines          9413       9420         +7     
  Branches       1155       1158         +3     
================================================
+ Hits           5793       5800         +7     
  Misses         3620       3620

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Victor-M-Giraldo · 2024-01-23T21:47:45Z

Seeing lots of errors for the lint. Could it be the upside down question marks/exclamation points, or letters with accents on them?

Update: It's good now, nevermind.

dyc3

Looks good, just needs a minor fix

client/src/components/navbar/LocaleSelector.vue

coderabbitai

Review Status

Actionable comments generated: 15

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 1ee7564 and e9634aa.

Files selected for processing (2)

client/src/components/navbar/LocaleSelector.vue (1 hunks)
client/src/locales/es.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

client/src/components/navbar/LocaleSelector.vue

Additional comments: 2

client/src/locales/es.ts (2)

1-1: Ensure that the imported types (OttWebsocketError, BehaviorOption, Role) are used within this file, otherwise, the import is unnecessary.

3-383: Check for consistency in translation quality, appropriate context, and correct spelling. Verify that the translations are accurate and make sense within the application's context.

client/src/locales/es.ts

Victor-M-Giraldo · 2024-01-23T22:25:48Z

Ah forgot a few. I'll change those.

Victor-M-Giraldo · 2024-01-23T22:45:00Z

I did run yarn lint, it's giving me errors on my desktop though. I'll run it on my laptop and push again in a second.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e9634aa and eb3ecd1.

Files selected for processing (1)

client/src/locales/es.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

client/src/locales/es.ts

Victor Giraldo and others added 3 commits January 21, 2024 20:55

began spanish localization

550fcc2

Merge branch 'dyc3:master' into spanish-localization

76599d1

Finished spanish localization

1ee7564

Victor-M-Giraldo requested a review from dyc3 as a code owner January 23, 2024 21:40

Victor-M-Giraldo changed the title ~~spanish localization~~ Client: Spanish Localization Jan 23, 2024

coderabbitai bot reviewed Jan 23, 2024

View reviewed changes

Victor-M-Giraldo changed the title ~~Client: Spanish Localization~~ client: Spanish Localization Jan 23, 2024

ran yarn lint

3969b6b

dyc3 added client Improvements or additions to the web client i18n aka Internationalization, Localization, Translation labels Jan 23, 2024

dyc3 approved these changes Jan 23, 2024

View reviewed changes

client/src/components/navbar/LocaleSelector.vue Outdated Show resolved Hide resolved

requested changes

e9634aa

coderabbitai bot reviewed Jan 23, 2024

View reviewed changes

missed a few

60866d1

ran yarn lint

eb3ecd1

coderabbitai bot reviewed Jan 23, 2024

View reviewed changes

dyc3 approved these changes Jan 23, 2024

View reviewed changes

dyc3 merged commit f001c2e into dyc3:master Jan 23, 2024
16 of 18 checks passed

Victor-M-Giraldo deleted the spanish-localization branch January 23, 2024 23:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client: Spanish Localization #1263

client: Spanish Localization #1263

Victor-M-Giraldo commented Jan 23, 2024 •

edited

Loading

coderabbitai bot commented Jan 23, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

codecov bot commented Jan 23, 2024 •

edited

Loading

Victor-M-Giraldo commented Jan 23, 2024 •

edited

Loading

dyc3 left a comment

coderabbitai bot left a comment

Victor-M-Giraldo commented Jan 23, 2024

Victor-M-Giraldo commented Jan 23, 2024

coderabbitai bot left a comment

client: Spanish Localization #1263

client: Spanish Localization #1263

Conversation

Victor-M-Giraldo commented Jan 23, 2024 • edited Loading

coderabbitai bot commented Jan 23, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 23, 2024 • edited Loading

Codecov Report

Victor-M-Giraldo commented Jan 23, 2024 • edited Loading

dyc3 left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

Victor-M-Giraldo commented Jan 23, 2024

Victor-M-Giraldo commented Jan 23, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

Victor-M-Giraldo commented Jan 23, 2024 •

edited

Loading

coderabbitai bot commented Jan 23, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Jan 23, 2024 •

edited

Loading

Victor-M-Giraldo commented Jan 23, 2024 •

edited

Loading