Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perform partial room unloads when monolith is shutting down #1183

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Dec 18, 2023

fixes #1120

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4e8432e) 61.3205% compared to head (74a314b) 61.3081%.
Report is 4 commits behind head on master.

Files Patch % Lines
server/roommanager.ts 76.6666% 7 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             master      #1183        +/-   ##
================================================
- Coverage   61.3205%   61.3081%   -0.0125%     
================================================
  Files           115        115                
  Lines          9390       9617       +227     
  Branches       1135       1139         +4     
================================================
+ Hits           5758       5896       +138     
- Misses         3632       3721        +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 18, 2023

2 failed tests on run #757 ↗︎

2 63 1 0 Flakiness 0

Details:

Merge 74a314b into 82d5b6f...
Project: OpenTogetherTube Commit: d8337ed9c7 ℹ️
Status: Failed Duration: 03:28 💡
Started: Dec 18, 2023 6:55 PM Ended: Dec 18, 2023 6:59 PM
Failed  RoomSettingsForm.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Screenshots Video
Failed  ShareInvite.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Screenshots Video

Review all test suite changes for PR #1183 ↗︎

@dyc3 dyc3 merged commit cb4a6db into master Dec 19, 2023
14 of 16 checks passed
@dyc3 dyc3 deleted the save-queues-on-exit branch December 19, 2023 16:54
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previous Queues may be lost when a monolith restarts
1 participant