Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous Queues may be lost when a monolith restarts #1120

Closed
2 of 3 tasks
dyc3 opened this issue Oct 31, 2023 · 0 comments · Fixed by #1183
Closed
2 of 3 tasks

Previous Queues may be lost when a monolith restarts #1120

dyc3 opened this issue Oct 31, 2023 · 0 comments · Fixed by #1183
Assignees
@dyc3
Labels
bug Something isn't working regression An intentional behavior that worked before does not work now server Improvements or additions to the server

Comments

@dyc3
Copy link
Owner

dyc3 commented Oct 31, 2023

Current Behavior

Sometimes, previous queues get lost or not updated in certain edge cases

Expected Behavior

Previous queues should always get saved when a room is unloaded

Steps To Reproduce

  1. Create a permanent room
  2. Queue up a few videos
  3. Disconnect from the room
  4. Restart monolith
  5. Wait for Room to expire in redis (or delete the key in redis to avoid waiting)
  6. Reconnect to the same room
  7. See that the previous queue is not restored

Environment

  • This happens on the official site, opentogethertube.com
  • This happens using a self-hosted version.
  • I'm using the docker image.

Anything else?

Likely related to #1073

I think the solution could be saving all queues on exit.

Related docs for that:
@dyc3 dyc3 added bug Something isn't working uncomfirmed Bug has not yet been confirmed, do not start a fix. labels Oct 31, 2023
@dyc3 dyc3 removed the uncomfirmed Bug has not yet been confirmed, do not start a fix. label Dec 6, 2023
@dyc3 dyc3 added server Improvements or additions to the server regression An intentional behavior that worked before does not work now labels Dec 18, 2023
@dyc3 dyc3 self-assigned this Dec 18, 2023
@dyc3 dyc3 moved this from Todo to In Progress in OTT Horizontal Scaling Dec 18, 2023
@dyc3 dyc3 mentioned this issue Dec 18, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in OTT Horizontal Scaling Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyc3 dyc3

Labels
bug Something isn't working regression An intentional behavior that worked before does not work now server Improvements or additions to the server
Projects
OTT Horizontal Scaling
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perform partial room unloads when monolith is shutting down dyc3/opentogethertube
1 participant
@dyc3