Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users sometimes show up multiple times in the user list, and never go away #1207

Closed
2 of 3 tasks
dyc3 opened this issue Jan 9, 2024 · 2 comments · Fixed by #1214
Closed
2 of 3 tasks

Users sometimes show up multiple times in the user list, and never go away #1207

dyc3 opened this issue Jan 9, 2024 · 2 comments · Fixed by #1214
Assignees
@dyc3
Labels
balancer Improvements or additions to the load balancer bug Something isn't working regression An intentional behavior that worked before does not work now
Milestone
Load Balancing

Comments

@dyc3
Copy link
Owner

dyc3 commented Jan 9, 2024 •
edited
Loading

Current Behavior

Sometimes, after a while of using OTT, users will show up in the user list multiple times.

image

Expected Behavior

When users disconnect, they should always be removed from the user list.

Steps To Reproduce

  1. Create a room
  2. Join with 2 clients
  3. Restart balancer
  4. See phantom user in user list

Environment

  • This happens on the official site, opentogethertube.com
  • This happens using a self-hosted version.
  • I'm using the docker image.

Anything else?

Found while testing the load balancer on the staging branch, but I've seen this happen before too.
@dyc3 dyc3 added bug Something isn't working regression An intentional behavior that worked before does not work now client Improvements or additions to the web client server Improvements or additions to the server labels Jan 9, 2024
dyc3 added a commit that referenced this issue Jan 9, 2024
@dyc3
adjust logging around client disconnects/leaves to debug #1207
7b02df2
dyc3 added a commit that referenced this issue Jan 9, 2024
@dyc3
adjust logging around client disconnects/leaves to debug #1207 (#1208)
6736ca4
@dyc3

This comment was marked as outdated.

Sign in to view
@dyc3 dyc3 added balancer Improvements or additions to the load balancer and removed server Improvements or additions to the server client Improvements or additions to the web client labels Jan 9, 2024
@dyc3 dyc3 added this to the Load Balancing milestone Jan 9, 2024
@dyc3 dyc3 self-assigned this Jan 10, 2024
@dyc3 dyc3 moved this from Todo to In Progress in OTT Horizontal Scaling Jan 11, 2024
dyc3 added a commit that referenced this issue Jan 11, 2024
@dyc3
balancer: fix clients not being removed from balancer context on disc…
f8fbac8 
…onnect

possibly related to #1207?
@dyc3
Copy link
Owner Author

dyc3 commented Jan 11, 2024 •
edited
Loading

Actually, I don't think there's anything wrong with the balancer that's causing this. I think I've narrowed it to a problem in the monolith. I think what's happening is that it's not properly removing clients when balancers get disconnected. I've found a repro, updated it in the issue description.

dyc3 added a commit that referenced this issue Jan 11, 2024
@dyc3
balancer: fix clients not being removed from balancer context on disc…
82b8584 
…onnect

possibly related to #1207?
@dyc3 dyc3 mentioned this issue Jan 11, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in OTT Horizontal Scaling Jan 12, 2024
dyc3 added a commit that referenced this issue Jan 12, 2024
@dyc3
balancer: fix clients not being removed from balancer context on disc…
e4278c9 
…onnect (#1212)

* balancer: fix clients not being removed from balancer context on disconnect
possibly related to #1207?

* add a unit test
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this issue Jan 26, 2024
@dyc3 @cjrkoa
adjust logging around client disconnects/leaves to debug dyc3#1207 (d…
2445603 
…yc3#1208)
cjrkoa pushed a commit to cjrkoa/opentogethertube that referenced this issue Jan 26, 2024
@dyc3 @cjrkoa
balancer: fix clients not being removed from balancer context on disc…
72e2fc8 
…onnect (dyc3#1212)

* balancer: fix clients not being removed from balancer context on disconnect
possibly related to dyc3#1207?

* add a unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyc3 dyc3

Labels
balancer Improvements or additions to the load balancer bug Something isn't working regression An intentional behavior that worked before does not work now
Projects
OTT Horizontal Scaling
Archived in project
Milestone
Load Balancing
1 participant
@dyc3