Merged
Conversation
The fix (about to be made) will be based off of the stable (0.3.1) branch. Then I'll cherry pick the commits that fix the problem into master.
Owner
Author
|
Had to bump version to 0.3.3. The autorelease process is extremely conservative in its testing. It uploads to the test.pypi.org server, then re-downloads and runs tests. Unfortunately, if there's a problem in the test procedure (as there was here -- the same problem that this release will fix) then the test will fail. And pypi doesn't let you replace a package using the same version number. Honestly, I could merge this while failing, and it would be fine. Or another approach is to do a post-release, i.e., 0.3.2.post1. But I'm fine just skipping the 0.3.2 and going straight to 0.3.3. |
Collaborator
|
LGTM feel free to merge (I agree on the skip part) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for problems in our testing procedure. See #45 for details. This should have no effect on users.