Conversation
dwhswenson
added
bug
upstream_changed
Owner
Author
|
Apparently the problem was that Travis already had pytest (3.3) installed. Recent versions of pytest-cov require pytest>3.6. Our request to install pytest as part of our testing requirements was met with "already installed" (at 3.3). The solution is to request up-to-date versions of all testing packages (add a Better dependency resolution would help (e.g., using conda). But I want to use pip installs for the testing environment on Travis (we use conda on AppVeyor). I assume this will pass the AppVeyor builds, since this problem doesn't exist there. Once it does, I'll merge. @sroet, you're welcome to take a look, but I don't think the 2-character change requires a review! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis is currently installing old versions of pytest with a newer version of pytest-cov, causing errors in tests. This PR is intended to fix that.