Update BSK with AI Chat deeplink feature flag #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunn
commented
Jan 10, 2025
| @@ -53,7 +53,7 @@ final class TabURLInterceptorDefault: TabURLInterceptor { | |||
| ] | |||
|
|
|||
| func allowsNavigatingTo(url: URL) -> Bool { | |||
| if url.isDuckAIURL { | |||
| if featureFlagger.isFeatureOn(.aiChatDeepLink), url.isDuckAIURL { | |||
There was a problem hiding this comment.
Added extra check to prevent this flow in case the FF is off.
afterxleep
approved these changes
Jan 10, 2025
Bunn
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 10, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/1204167627774280/1209108545833453/f iOS PR: duckduckgo/iOS#3786 macOS PR: duckduckgo/macos-browser#3720 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: CC: **Description**: Add deeplink feature flag for AI Chat
Bunn
force-pushed
the
bunn/aichat/deeplink-ff
branch
from
3439d92 to
bac8c86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204167627774280/1209108545833453/f
Description:
Update BSK with AI Chat deeplink feature flag
Steps to test this PR:
aichat enabled, deeplink disabled -> http://jsonblob.com/api/1327200110144315392
aichat enabled, deeplink enabled -> http://jsonblob.com/api/1327200251714658304