Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duck.ai deeplink #3775

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Duck.ai deeplink #3775

merged 7 commits into from
Jan 9, 2025

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Jan 7, 2025

Task/Issue URL: https://app.asana.com/0/1204167627774280/1208991515313413/f
Tech Design URL:
CC:

Description:

Add deep-link integration to duck.ai. Opening duck.ai from anywhere should open the custom webview instead of a new tab

Steps to test this PR:

  1. Host this HTML
  2. Change this to return true
  3. Make sure that tapping every button opens the custom AI Chat view instead of a tab
  4. Try typing duck.ai directly in the address bar and make sure it opens the custom AI Chat
  5. Make sure that there are no changes in behavior without the change done here

@Bunn Bunn requested a review from afterxleep January 8, 2025 17:30
@Bunn Bunn marked this pull request as ready for review January 8, 2025 17:30
@Bunn Bunn changed the title [WIP] Duck.ai deeplink Duck.ai deeplink Jan 9, 2025
Copy link
Collaborator

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

01-09 at 17 24

Works as expected. :shipit:

@Bunn Bunn merged commit b41e8e7 into main Jan 9, 2025
13 checks passed
@Bunn Bunn deleted the bunn/aichat/deeplink branch January 9, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants