fix: Check Permission properly #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atm1504
requested changes
Jun 18, 2019
app/src/main/java/com/example/saar/Profile/EditProfileFragment.java
Outdated
Show resolved
Hide resolved
|
@atm1504 if any permission is not given, it will be automatically asked when edit profile is opened. |
|
@somenath1435 what if I press cancel again in the re-prompt. |
|
Every time edit profile is opened, if permission is not given, it asks for it |
Come on. This permission prompts up when we open the edit profile fragment. But if we deny them, we still stay in the edit page. Now, in such a case if u want to change the picture, then it will check if permission is granted or not. if, its not granted re-prompt the function that asks for permission. |
|
@atm1504 let's do one thing, when user click on FAB then dialog should be shown ,not when edit profile is opened. |
|
@somenath1435 u mean when we try to change the picture we should ask for it. No, that's not a good idea. Users should be aware of the fact that the edit profile uses this permission. The problem might arise when releasing in google play. It's better to shift the entire permission asking to the home fragment itself. |
atm1504
approved these changes
Jun 19, 2019
atm1504
added a commit
that referenced
this pull request
Jun 20, 2019
* Change profile photo update progress bar * Added Label for Edittext * added margin * Cache skip in Glide * Edit Profile back button handled * feat: Implement group notificatio * feat: Implement change password api * Added Utils class * reformat lines spacing * typo fix * Removed unnecessary toast * feat: Implement resend OTP API * feat: Refactor logout, unsubscribe notification * reformat spacing * Added back button in otp activity * Removed back button in Login page * feat: Handle offline mode in login signup * Handled empty edittext * fix: Display employment type * changed some fields * View fullscreen gallery image * Add signup error dialog * empty edittext * Fixed Nav issue on back pressed * Handle back from profile page * Add scrollview * Handled Orientation Change in Fragments * Updated Retrofit link (#202) * Added Videos Fragment (#203) * feat: Implement forgot password feature (#206) * Enhance UI of event details page (#208) * Visibility in View Profile incase of empty fields (#209) * feat: Add videos of saar (#211) * remove toast (#215) * Added Square Logo (#216) * fix: skip press issue in login page (#218) * Enhance ui of video fragment (#219) * Revert "fix: skip press issue in login page (#218)" (#220) This reverts commit 88f8666. * fix: Few UI improvements (#222) * UI fix in Change password * Improved login UI * Otp pin (#223) * Clear otp pinview * Fix errors * remove log messages (#225) * remove log statements * fix team fragment * Update changes * Update changes * Mainactivity as opening screen (#230) * patch: CircleImageView issue (#231) * Encoded Bitmap * Improved Homepage and nav header * fix: Check Permission properly (#227) * Check Permission properly * recheck permission * feat: Implement skip login feature (#233)
atm1504
added a commit
that referenced
this pull request
Jun 21, 2019
* Change profile photo update progress bar * Added Label for Edittext * added margin * Cache skip in Glide * Edit Profile back button handled * feat: Implement group notificatio * feat: Implement change password api * Added Utils class * reformat lines spacing * typo fix * Removed unnecessary toast * feat: Implement resend OTP API * feat: Refactor logout, unsubscribe notification * reformat spacing * Added back button in otp activity * Removed back button in Login page * feat: Handle offline mode in login signup * Handled empty edittext * fix: Display employment type * changed some fields * View fullscreen gallery image * Add signup error dialog * empty edittext * Fixed Nav issue on back pressed * Handle back from profile page * Add scrollview * Handled Orientation Change in Fragments * Updated Retrofit link (#202) * Added Videos Fragment (#203) * feat: Implement forgot password feature (#206) * Enhance UI of event details page (#208) * Visibility in View Profile incase of empty fields (#209) * feat: Add videos of saar (#211) * remove toast (#215) * Added Square Logo (#216) * fix: skip press issue in login page (#218) * Enhance ui of video fragment (#219) * Revert "fix: skip press issue in login page (#218)" (#220) This reverts commit 88f8666. * fix: Few UI improvements (#222) * UI fix in Change password * Improved login UI * Otp pin (#223) * Clear otp pinview * Fix errors * remove log messages (#225) * remove log statements * fix team fragment * Update changes * Update changes * Mainactivity as opening screen (#230) * patch: CircleImageView issue (#231) * Encoded Bitmap * Improved Homepage and nav header * fix: Check Permission properly (#227) * Check Permission properly * recheck permission * feat: Implement skip login feature (#233) * Updated readme * fix: backbutton in login signup page (#235) * fix: Few Improvements (#237) * Fixed issue on Home Fragment * Improvement in Login Page * Deselected Selected item in NavDrawer * chore: Update readme (#238) * Added screenshots in Readme * Added Libraries list * Upgrade the version release in the app (#239) * fix: backbutton in login signup page * chnage version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224
Changes: Before changing profile picture , proper permission check is done.