Skip to content

Conversation

@typhonius
Copy link

This should help with #1641 & #752 when using Drush runserver on a D7 site.

@greg-1-anderson
Copy link
Member

It's not easy creating a runserver prepend file that works right; seems that few folks would have the need or skill to use this. Would it be possible to fix the problems in the referenced issues directly in the appropriate Drush prepend file?

@typhonius
Copy link
Author

Really it's only the bit which looks for actual files and doesn't cause PHP to be a sad 🐼 when you want to send a path with a period in.

@greg-1-anderson
Copy link
Member

How does this PR fix the problem with paths with a period?

@typhonius
Copy link
Author

So my usecase for this was to use the d8 router file on a d7 site. I just relooked at the D7 prepend file and I'd probably have to do something like:

  • Check if the path had a period in
  • Check if the file existed on the server
  • If yes to 1 and no to 2 call index.php directly with the path

I'm not really even sure if that'd work though.

@greg-1-anderson
Copy link
Member

Seems to me that I tried the D8 router file with D7, to see if we could have just one version, and it did not work. It would be useful if someone could do the full matrix of testing -- Drupal verison vs. special characters in filename vs. different router files, etc., and report which combinations work and which do not. Ideally, Drush should always select a prepend file for the user that just worked.

@kenorb
Copy link
Contributor

kenorb commented Jan 13, 2016

Related PR: #1658

@weitzman
Copy link
Member

lets close in favor of #1658

@weitzman weitzman closed this Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants