Use the d8-rs-router.php for drupal 7 #1658
Conversation
|
I think the test failed for unknown reason and it's not related to this PR, can the test be refreshed? |
|
Re-ran and it failed again. Agree that failure looks unrelated. Hmmmm. |
|
I've seen some folks asking about this for Drupal 7 again. Needs to be rebased against master. |
|
@MartijnBraam any chance I can have commit access to the forked repo? I'd love to get this up to date so it could be merged in. |
|
@darthsteven I have given you commit access |
|
@MartijnBraam amazing! Thank you. |
…erver-with-dot-in-url
|
I've updated the branch to be in-sync with master, all tests are passing! I guess it's worth noting that this will stop the overrides to |
|
Right, I've re-instated the code from runserver-prepend that was doing the conf and watchdog magic. |
| $uid = $log_entry['user']->uid; | ||
| } | ||
| else { | ||
| $uid = $log_entry['user']->id(); |
There was a problem hiding this comment.
This looks like D8 code in a D7 file.
|
With this patch D8 worked fine but D7 did not. I got pages without stylesheets and the homepage was empty. |
|
If we don't need to support Drupal 6 then let's drop that and that'll make the code much simpler. I'll look into why it didn't work for Drupal 7 and get fixes in as required. |
|
Some colleagues and I are so much interested in fixing this. @darthsteven anything I could help you with? |
|
I've been working on a D7 site and have been experiencing the problem with image styles not being generated. Disabling clean URLs resolves this problem but but a proper fix would be great. I'm happy to help if I can. |
|
I've added a follow-on PR in #2501 |
|
update: the follow-on PR was merged, this issue can probably be closed? |
9 participants
The d8-rs-router.php from the runserver module seems to work fine for drupal-7 and fixes the issue of paths containing a dot resolving to a 404 page. See issue #1641