Skip to content

Ensure the result of GpsLocation is consistant when running the regression tests #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefanlenselink wants to merge 1 commit into from
Closed

Ensure the result of GpsLocation is consistant when running the regression tests #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions MetadataExtractor/Formats/QuickTime/QuickTimeMetadataReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,26 @@ void UuidHandler(AtomCallbackArgs a)

void UserDataHandler(AtomCallbackArgs a)
{
switch (a.TypeString)
var key = a.TypeString;
if (key.Length < 1)
{
return;
}
if (key[0] == 0xa9 || key[0] == 0x40)
{
//Tag ID's beginning with the copyright symbol (hex 0xa9) are multi-language text
//Alternate language tags are accessed by adding a dash followed by a 3-character ISO 639-2 language code to the tag name.

//some stupid Ricoh programmer used the '@' symbol instead of the copyright symbol in these tag ID's for the Ricoh Theta Z1 and maybe other models

//For now we don't support those, we will strip the copyright and locale info
key = key.Substring(1);
key = key.Split('-')[0];
}

switch (key)
{
case "?xyz":
case "xyz":
var stringSize = a.Reader.GetUInt16();
a.Reader.Skip(2); // uint16 language code
var stringBytes = a.Reader.GetBytes(stringSize);
Expand Down