Ensure the result of GpsLocation is consistant when running the regression tests#419
Closed
stefanlenselink wants to merge 1 commit intodrewnoakes:mainfrom
Closed
Conversation
…ssion tests in metadata-extractor-images for both mov and mp4 files.
Owner
|
Thanks, this looks good. I'll need to pull it down and run across the regression suite to see what's what. Also I've been slowly working to improve IsoBmff parsing, which would help with this here. We'd be comparing the original byte arrays, rather than strings (which can hit problems with encoding). |
Owner
|
A simpler fix for this was in #433, so this PR is obsolete now. The string parsing stuff here wouldn't work, as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While preparing a different pull request and running the regression tests tests in metadata-extractor-images for both mov and mp4 files differ in the GpsLocation.
The cause is the Metadata tag is starting with a copyright symbol; while the source-code did not have any / use to have it but it's not there anymore.
Proposed solution is to strip-off the Copyright (and for completeness the @ symbol) and possibly any localisation and compare to the base tag name.
Inspriration / comments taken from: https://exiftool.org/TagNames/QuickTime.html