Pass init options from MultiProcessConsumer down to SimpleConsumer #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -103,7 +107,8 @@ class MultiProcessConsumer(Consumer): | |||
| def __init__(self, client, group, topic, auto_commit=True, | |||
| auto_commit_every_n=AUTO_COMMIT_MSG_COUNT, | |||
| auto_commit_every_t=AUTO_COMMIT_INTERVAL, | |||
| num_procs=1, partitions_per_proc=0): | |||
| num_procs=1, partitions_per_proc=0, | |||
| simple_consumer_options={}): | |||
There was a problem hiding this comment.
You... probably don't want to hard code an object in a function prototype. It's a source of endless bugs.
There was a problem hiding this comment.
A mutable dict as a kwarg has import level sideeffects, it'll be one dict shared across all instances. Please assign this as None and then check inside the function.
|
@mahall This doesn't merge cleanly. Can you get it working again? |
|
#336 improves on this a bit -- plan to merge that and close this unless there are strong objections. |
|
#336 merged -- thanks for your work on this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248.