Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiProcessConsumer Cannot Set Options of SimpleConsumer Workers #248

Closed
rhema opened this issue Sep 26, 2014 · 2 comments
Closed

MultiProcessConsumer Cannot Set Options of SimpleConsumer Workers #248

rhema opened this issue Sep 26, 2014 · 2 comments
Labels
consumer
Milestone
0.9.4 Release

Comments

@rhema
Copy link

rhema commented Sep 26, 2014

SimpleConsumer can be instantiated with options such as fetch_size_bytes, buffer_size, and max_buffer_size. MultiProcessConsumer uses a pool SimpleConsumer workers, but instantiates them using their default configuration. This is a problem when log messages are large enough to need larger (fetch_size_bytes, buffer_size, and max_buffer_size) than normal.
@dpkp dpkp added the consumer label Sep 26, 2014
@mahall
Copy link

mahall commented Oct 16, 2014

We are affected by this as well. I'll throw a pull request together that passes named arguments down to the SimpleConsumer and see what they think.

@mahall mahall mentioned this issue Oct 16, 2014
Closed
@vshlapakov vshlapakov mentioned this issue Mar 3, 2015
Merged
@dpkp
Copy link
Owner

dpkp commented Mar 31, 2015

fixed in #336

@dpkp dpkp closed this as completed Mar 31, 2015
@dpkp dpkp added this to the 0.9.4 Release milestone Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consumer
Projects
None yet
Milestone
0.9.4 Release
Development

Successfully merging a pull request may close this issue.

Pass init options from MultiProcessConsumer down to SimpleConsumer mahall/kafka-python
3 participants
@rhema @mahall @dpkp