Add list consumer groups offsets #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
add-list-consumer-groups-offsets
branch
3 times, most recently
from
e2f25cb to
06f6989
Compare
jeffwidman
force-pushed
the
add-list-consumer-groups-offsets
branch
2 times, most recently
from
80a1a9f to
26e14b6
Compare
This was referenced Nov 18, 2018
jeffwidman
force-pushed
the
add-list-consumer-groups-offsets
branch
2 times, most recently
from
aab66d4 to
3eba52d
Compare
Support fetching the offsets of a consumer group. Note: As far as I can tell (the Java code is a little inscrutable), the Java AdminClient doesn't allow specifying the `coordinator_id` or the `partitions`. But I decided to include them because they provide a lot of additional flexibility: 1. allowing users to specify the partitions allows this method to be used even for older brokers that don't support the OffsetFetchRequest_v2 2. allowing users to specify the coordinator ID gives them a way to bypass a network round trip. This method will frequently be used for monitoring, and if you've got 1,000 consumer groups that are being monitored once a minute, that's ~1.5M requests a day that are unnecessarily duplicated as the coordinator doesn't change unless there's an error.
jeffwidman
force-pushed
the
add-list-consumer-groups-offsets
branch
from
3eba52d to
b4bb1d5
Compare
|
The tests passed previously when this PR included a commit from another PR that hadn't been merged yet... so I just rebased to clean up the diff here in the Github UI, and now merge w/o waiting for tests to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add list_consumer_group_offsets() to support fetching the offsets of a consumer group.
Note: As far as I can tell (the Java code is a little inscrutable), the
Java AdminClient doesn't allow specifying the
coordinator_idor thepartitions.But I decided to include them because they provide a lot of additional
flexibility:
allowing users to specify the partitions allows this method to be used even for
older brokers that don't support the OffsetFetchRequest_v2
allowing users to specify the coordinator ID gives them a way to
bypass a network round trip. This method will frequently be used for
monitoring, and if you've got 1,000 consumer groups that are being
monitored once a minute, that's ~1.5M requests a day that are
unnecessarily duplicated as the coordinator doesn't change unless
there's an error.
Fix #950
This change is