Skip to content

Add tests for KafkaAdminClient #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wbarnha opened this issue Mar 8, 2024 · 0 comments
Open

Add tests for KafkaAdminClient #114

wbarnha opened this issue Mar 8, 2024 · 0 comments

Comments

@wbarnha
Copy link
Collaborator

wbarnha commented Mar 8, 2024

I need to add tests for the KafkaAdmin changes I made:

  1. Stop using broker-errors for client-side problems dpkp/kafka-python#1639
  2. Fix KafkaAdmin send to controller dpkp/kafka-python#1640
  3. Add group coordinator lookup dpkp/kafka-python#1641
  4. Fix describe groups dpkp/kafka-python#1642
  5. Add list consumer groups offsets dpkp/kafka-python#1643
  6. Set a clear default value for validate_only / include_synonyms dpkp/kafka-python#1645

I didn't have time yet to do tests... Given that the existing KafkaAdminClient code currently on the master branch is broken, sometimes in subtle ways, I decided fine to put them up as-is since then the code will be mostly working, and then later add tests to prevent regressions.

Frankly, the test fixtures are a bit of a mess, so I will probably instead go the route of finishing dpkp#1193, as that will both simplify the code drastically and require a few fixture changes.

And then after that tackle the tests/missing coverage.

But creating this and assigning it to myself so that I don't forget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant