Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align .editorconfig with WinForms #10080

Merged
merged 2 commits into from
Nov 18, 2024

Commits on Nov 16, 2024

  1. Align .editorconfig with WinForms

    This effectively copies the .editorconfig from WinForms to align the baseline.
    
    As there are many deviations from the rules in the sources, added a temporary .editorconfig in the product src directory. This will need to have rules pulled bit by bit as the projects are fixed. Most of the rules are pretty easy to fix, but would require some pretty massive codefix changes. They are reasonably safe to do, but they will create disruption for existing PRs as they'll need to rebase.
    
    Created another .editorconfig specifically for the cycle breaker projects. Fixed the headers in the cycle breakers, but otherwise mostly left them alone.
    
    Test projects were updated to pass without needing any overrides. As a general rule, we try to not disable rules for test projects as we want to keep good habits over the entire codebase.
    
    The sooner the automated fixes are done, the better. It is better to have this done before Preview 1 and it is better to aggressively push to do them. Don't wait for full test passes inbetween changes, do a full pass once they are committed. The recommendation:
    
    1. For each rule where there is an automated fix, run the fix and create a PR that says that you ran the codefix
    2. Sanity review and merge each as quickly as possible (check off, merge as soon as green)
    3. Run a full test pass when finished
    
    Clearing the automated fixes should be able to be done in a couple weeks at most. Once the rules are turned on it will significantly improve the contribution process. Less clean up to review, less iteration over rules, etc.
    JeremyKuhne committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    ad1f7b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    300b187 View commit details
    Browse the repository at this point in the history