Align .editorconfig with WinForms #10080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively copies the .editorconfig from WinForms to align the baseline. As there are many deviations from the rules in the sources, added a temporary .editorconfig in the product src directory. This will need to have rules pulled bit by bit as the projects are fixed. Most of the rules are pretty easy to fix, but would require some pretty massive codefix changes. They are reasonably safe to do, but they will create disruption for existing PRs as they'll need to rebase. Created another .editorconfig specifically for the cycle breaker projects. Fixed the headers in the cycle breakers, but otherwise mostly left them alone. Test projects were updated to pass without needing any overrides. As a general rule, we try to not disable rules for test projects as we want to keep good habits over the entire codebase. The sooner the automated fixes are done, the better. It is better to have this done before Preview 1 and it is better to aggressively push to do them. Don't wait for full test passes inbetween changes, do a full pass once they are committed. The recommendation: 1. For each rule where there is an automated fix, run the fix and create a PR that says that you ran the codefix 2. Sanity review and merge each as quickly as possible (check off, merge as soon as green) 3. Run a full test pass when finished Clearing the automated fixes should be able to be done in a couple weeks at most. Once the rules are turned on it will significantly improve the contribution process. Less clean up to review, less iteration over rules, etc.
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
the
PR
|
This is a step towards #10017. |
|
#10011 is one of the larger semi-automated fixes that would apply towards enabling the disabled rules in this PR. |
|
Thank you @JeremyKuhne for the help here, we will iteratively resolve the pending failures. |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively copies the
.editorconfigfrom WinForms to align the baseline.As there are many deviations from the rules in the sources, added a temporary
.editorconfigin the product src directory. This will need to have rules pulled bit by bit as the projects are fixed. Most of the rules are pretty easy to fix but would require some pretty massive code fix changes. They are reasonably safe to do, but they will create disruption for existing PRs as they'll need to rebase.Created another
.editorconfigspecifically for the cycle breaker projects. Fixed the headers in the cycle breakers, but otherwise mostly left them alone.Test projects were updated to pass without needing any overrides. As a general rule, we try to not disable rules for test projects as we want to keep good habits over the entire codebase.
The sooner the automated fixes are done, the better. It is better to have this done before Preview 1 and it is better to aggressively push to do them. Don't wait for full test passes in-between changes, do a full pass once they are committed. The recommendation:
Clearing the automated fixes should be able to be done in a couple weeks at most. Once the rules are turned on it will significantly improve the contribution process. Less cleanup to review, less iteration over rules, etc.
Microsoft Reviewers: Open in CodeFlow