Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChannelLayer tests #3635

Merged

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented May 13, 2019

Fix SynchronizationContext issue when calling IDuplexSessionChannel.Receive directly.
Fix tests which aren't correctly closing session.

…eceive directly. Fix tests which aren't correctly closing session
@StephenBonikowsky
Copy link
Member

I believe this is the fix for issue #3610 correct?

@StephenBonikowsky
Copy link
Member

The CI failures are unrelated to this PR, they are related to two test failures, one due to an infrastructure issue that is being investigated and the other is a bug in CoreFx that has already been fixed for which we have to pick-up the latest packages for test.

@StephenBonikowsky StephenBonikowsky merged commit d6397d5 into dotnet:master May 14, 2019
StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this pull request May 14, 2019
StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this pull request May 15, 2019
StephenBonikowsky added a commit that referenced this pull request May 15, 2019
@mconnew mconnew deleted the FixFreezingChannelLayerTests branch September 27, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants