Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets incorrectly posting continuations to application SynchronizationContext. #3610

Closed
StephenBonikowsky opened this issue May 8, 2019 · 2 comments
Closed

WebSockets incorrectly posting continuations to application SynchronizationContext. #3610

StephenBonikowsky opened this issue May 8, 2019 · 2 comments
Labels
bug This is a product bug. Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases.

Comments

@StephenBonikowsky
Copy link
Member

The WCF WebSocket implementation when calling receive on a WebSocket is posting continuations to the application SynchronizationContext which we expect to have dropped by that point but is not.

The fix is to drop the sync context, investigation is needed to identify the correct place to insert this fix.

Test cases failing due to this issue...
...Scenarios/Client/ChannelLayer/RequestReplyChannelShapeTests.4.0.0.cs

  • IRequestChannel_Async_Http_BasicHttpBinding
  • IRequestChannel_Async_Http_CustomBinding

...Scenarios/Client/ChannelLayer/DuplexChannelShapeTests.4.0.0.cs

  • IDuplexSessionChannel_Async_Tcp_NetTcpBinding

...Scenarios\Binding\WS\TransportWithMessageCredentialSecurity\WSHttpTransportWithMessageCredentialSecurityTests.cs

  • Https_SecModeTransWithMessCred_CertClientCredential_Succeeds

...Scenarios\Binding\WS\TransportWithMessageCredentialSecurity\BasicHttpTransportWithMessageCredentialSecurityTests.cs

  • Https_SecModeTransWithMessCred_CertClientCredential_Succeeds
@StephenBonikowsky StephenBonikowsky added the bug This is a product bug. label May 8, 2019
@StephenBonikowsky StephenBonikowsky added this to the 3.0 milestone May 8, 2019
@StephenBonikowsky StephenBonikowsky mentioned this issue May 14, 2019
Merged
@StephenBonikowsky StephenBonikowsky added the Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases. label May 23, 2019
@StephenBonikowsky
Copy link
Member Author

Verify tests are fixed now.

@StephenBonikowsky
Copy link
Member Author

None of these tests are being skipped now for this issue and they are passing on all runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This is a product bug. Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StephenBonikowsky