Skip to content

Utilize a separate pipeline for release tasks #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nagilson merged 34 commits into from
Jan 9, 2026
Merged

Utilize a separate pipeline for release tasks #2515

Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
8227f39
Try to publish in a separate pipeline
nagilson Dec 3, 2025
a49d632
Get the version in the release pipeline
nagilson Dec 3, 2025
dceb185
removes the publish step so we dont accidentally publish
nagilson Dec 3, 2025
1eeb718
Use CI VSCE since we may be blocked from global install
nagilson Dec 3, 2025
4bf9172
remove publish yml and update vsce minimum
nagilson Dec 4, 2025
61d8987
Fix Pipeline
nagilson Dec 4, 2025
3db9861
correctly check bool value
nagilson Dec 4, 2025
5b2d054
fix folder location
nagilson Dec 4, 2025
9d5b10f
properly use @self
nagilson Dec 4, 2025
719c36a
Merge remote-tracking branch 'upstream/main' into nagilson-separate-p…
nagilson Dec 5, 2025
6c0039b
fix artifact name
nagilson Dec 8, 2025
d3bce10
consume SBOM artifact
nagilson Dec 8, 2025
18dc1ce
Fix Pipeline
nagilson Dec 8, 2025
143d1a3
remove sbom disable logic - see if it works by default now
nagilson Dec 8, 2025
6d42a37
insert sbom into _manifest folder
nagilson Dec 8, 2025
452e9fb
signing should be conditional to prevent failures from trying to sign…
nagilson Dec 8, 2025
b6bc1e2
simplify artifact, sbom is now automatic
nagilson Dec 9, 2025
357e656
get version from the artifact
nagilson Dec 9, 2025
283f93d
fix ? version directory
nagilson Dec 9, 2025
af472e4
checkout self for package to make ci work
nagilson Dec 9, 2025
bf9abc4
try global install
nagilson Dec 9, 2025
5197cfc
rely on win
nagilson Dec 9, 2025
cd52562
fix pool
nagilson Dec 9, 2025
ddd0f98
try to get the package lock files as an artifact
nagilson Dec 9, 2025
b9677a9
don't create a separate 'signed' package
nagilson Dec 10, 2025
b17ea7c
Actually do the publish step now
nagilson Dec 10, 2025
62950ee
Fix whitespace
nagilson Jan 5, 2026
22b1cf2
Fix dependencies from updaets
nagilson Jan 5, 2026
758482e
convert to powershell over bash
nagilson Jan 5, 2026
289e992
Pin versions for lint to prevent sub ci issue
nagilson Jan 5, 2026
a15495f
Throw on error with powershell inline script to prevent bad continue
nagilson Jan 8, 2026
851685e
Fix Linting Rule
nagilson Jan 8, 2026
9dc717f
'test' parameter evaluation should use -eq
nagilson Jan 8, 2026
d0c08de
Add back publish step
nagilson Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions 1es-azure-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ variables:
value: true
- name: MicroBuildOutputFolderOverride
value: '$(Agent.TempDirectory)'
- name: TestBuild
value: $[eq(variables['Build.Reason'], 'Manual')]

resources:
repositories:
Expand Down Expand Up @@ -58,8 +60,6 @@ extends:
name: NetCore1ESPool-Internal
image: 1es-windows-2022
os: windows
sbom:
enabled: false # SBOM requires a special setup for node.js projects to ensure all dependencies are included.
policheck:
enabled: true
exclusionsFile: $(System.DefaultWorkingDirectory)\PoliCheckExclusions.xml
Expand Down Expand Up @@ -103,6 +103,7 @@ extends:
os: windows
useOneEngineeringPool: true
SignType: Real
TestBuild: $(TestBuild)
- template: pipeline-templates/sbom.yaml@self
parameters:
pool:
Expand Down
8 changes: 7 additions & 1 deletion msbuild/signJs/signJs.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,19 @@
<IsPackable>false</IsPackable>
<OutDir>$(MSBuildProjectDirectory)\$(JSOutputPath)\</OutDir>
<MicroBuild_SigningEnabled>true</MicroBuild_SigningEnabled>
<ShouldSign>true</ShouldSign>
</PropertyGroup>

<PropertyGroup Condition="'$(SignType)' == ''">
<SignType>test</SignType>
</PropertyGroup>

<ItemGroup>
<PropertyGroup Condition="$([System.String]::Equals('$(TestBuild)', 'true', StringComparison.OrdinalIgnoreCase))">
<ShouldSign>false</ShouldSign>
<MicroBuild_SigningEnabled>false</MicroBuild_SigningEnabled>
</PropertyGroup>

<ItemGroup Condition="'$(ShouldSign)' == 'true'">
<FilesToSign Include="$(OutDir)*.js">
<Authenticode>MicrosoftSHA2</Authenticode>
</FilesToSign>
Expand Down
9 changes: 8 additions & 1 deletion msbuild/signVsix/signVsix.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,15 @@
<MicroBuild_DoNotStrongNameSign>true</MicroBuild_DoNotStrongNameSign>
<IsPackable>false</IsPackable>
<OutDir>$(RepoRoot)packages\</OutDir>
<ShouldSign>true</ShouldSign>
</PropertyGroup>
<ItemGroup>

<PropertyGroup Condition="$([System.String]::Equals('$(TestBuild)', 'true', StringComparison.OrdinalIgnoreCase))">
<ShouldSign>false</ShouldSign>
<MicroBuild_SigningEnabled>false</MicroBuild_SigningEnabled>
</PropertyGroup>

<ItemGroup Condition="'$(ShouldSign)' == 'true'">
<FilesToSign Include="$(OutDir)*.signature.p7s">
<Authenticode>VSCodePublisher</Authenticode>
</FilesToSign>
Expand Down
Loading
Loading