Utilize a separate pipeline for release tasks #2515
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| trigger: none | ||
| pr: none | ||
|
|
||
| parameters: | ||
| - name: test | ||
| type: boolean | ||
| default: true | ||
|
|
||
| variables: | ||
| # This is expected to provide the PAT used to tag the release. | ||
| - group: DncEng-Partners-Tokens | ||
|
|
||
| resources: | ||
| repositories: | ||
| - repository: 1ESPipelineTemplates | ||
| type: git | ||
| name: 1ESPipelineTemplates/1ESPipelineTemplates | ||
| ref: refs/tags/release | ||
| pipelines: | ||
| - pipeline: officialBuildCI | ||
| source: dotnet-vscode-dotnet-runtime | ||
| branch: main | ||
| extends: | ||
| template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates | ||
| parameters: | ||
| pool: | ||
| name: NetCore1ESPool-Internal | ||
| image: 1es-windows-2022 | ||
| os: windows | ||
| customBuildTags: | ||
| - ES365AIMigrationTooling | ||
| stages: | ||
| - stage: PublishStage | ||
| jobs: | ||
| - deployment: PublishToMarketplace | ||
| displayName: PublishToMarketplace | ||
| environment: vscode-dotnetcore-extension-releases | ||
| pool: | ||
| name: NetCore1ESPool-Internal | ||
| image: 1es-windows-2022 | ||
| os: windows | ||
| templateContext: | ||
| type: releaseJob | ||
| isProduction: true | ||
| inputs: | ||
| - input: pipelineArtifact | ||
| pipeline: officialBuildCI | ||
| artifactName: vscode-dotnet-runtime-extension | ||
| destinationPath: $(Pipeline.Workspace) | ||
| - input: pipelineArtifact | ||
| pipeline: officialBuildCI | ||
| artifactName: package_files | ||
| destinationPath: $(Pipeline.Workspace)/package_files | ||
| strategy: | ||
| runOnce: | ||
| deploy: | ||
| steps: | ||
| - template: pipeline-templates/install-node.yaml@self | ||
| - template: pipeline-templates/list-file-structure.yaml@self | ||
| - bash: | | ||
|
Member
There was a problem hiding this comment.
Any reason this script needs to be bash on Windows? It then requires the script to run under WSL. Copilot could probably directly convert this to PowerShell pretty easily. Then, this entire job just uses PowerShell. |
||
| ARTIFACT_DIR="$(Pipeline.Workspace)" | ||
| VSIX_PATH=$(find "$ARTIFACT_DIR" -type f -name 'vscode-dotnet-runtime-*.vsix' | head -n 1) | ||
| if [ -z "$VSIX_PATH" ]; then | ||
| echo "##vso[task.logissue type=error]Unable to locate vscode-dotnet-runtime-*.vsix under $ARTIFACT_DIR" | ||
| exit 1 | ||
| fi | ||
|
|
||
| FILE_NAME=$(basename "$VSIX_PATH") | ||
| VERSION=${FILE_NAME#vscode-dotnet-runtime-} | ||
| VERSION=${VERSION%.vsix} | ||
|
|
||
| echo "Using version $VERSION derived from artifact $FILE_NAME" | ||
|
|
||
| PACKAGE_FILES_DIR="$ARTIFACT_DIR/package_files" | ||
| if [ -f "$PACKAGE_FILES_DIR/package.json" ]; then | ||
| (cd "$PACKAGE_FILES_DIR" && npm version "$VERSION" --allow-same-version) | ||
| fi | ||
|
|
||
| echo "##vso[task.setvariable variable=version;isOutput=true]$VERSION" | ||
| name: GetVersion | ||
| displayName: '❓ Get Version' | ||
| - pwsh: | | ||
| $packageFilesDir = Join-Path '$(Pipeline.Workspace)' 'package_files' | ||
| if (-not (Test-Path $packageFilesDir)) { | ||
| Write-Error "package_files artifact was not downloaded." | ||
| exit 1 | ||
| } | ||
|
|
||
| Push-Location $packageFilesDir | ||
| try { | ||
| npm ci | ||
| } | ||
| finally { | ||
| Pop-Location | ||
| } | ||
| displayName: '⬇️ Restore Node Dependencies' | ||
| - task: AzureCLI@2 | ||
| displayName: '🚀 Publish to Marketplace' | ||
| inputs: | ||
| azureSubscription: 'VSCode Marketplace Publishing' | ||
| scriptType: "pscore" | ||
| scriptLocation: 'inlineScript' | ||
| workingDirectory: '$(Pipeline.Workspace)/package_files' | ||
| inlineScript: | | ||
| $packagePath = Join-Path '$(Pipeline.Workspace)' 'vscode-dotnet-runtime-$(GetVersion.version).vsix' | ||
| $manifestPath = Join-Path '$(Pipeline.Workspace)' 'vscode-dotnet-runtime-$(GetVersion.version).manifest' | ||
| $signaturePath = Join-Path '$(Pipeline.Workspace)' 'vscode-dotnet-runtime-$(GetVersion.version).signature.p7s' | ||
|
|
||
| $publishArgs = @('publish', '--azure-credential', '--packagePath', $packagePath, '--manifestPath', $manifestPath, '--signaturePath', $signaturePath) | ||
| $publishArgsString = $publishArgs -join ' ' | ||
| If (${{ parameters.test }}) { | ||
| Write-Host "With a test-signed build, the command to publish is printed instead of run." | ||
| Write-Host "##[command]npx vsce $publishArgsString" | ||
|
|
||
| Write-Host "🔒 Verify PAT." | ||
| npx vsce verify-pat --azure-credential ms-dotnettools | ||
| } | ||
| Else { | ||
| Write-Host "##[command]npx vsce $publishArgsString" | ||
| npx vsce $publishArgs | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: For consistency, keep list elements,
- {prop}, aligned with the parent property. Thus,You did this with
variables:andrepositories:and other stuff below. It still works if it is indented extra, but it just adds to confusion about YAML if they're all not the same.