Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure failures to connect to the named pipe are propagated #6881

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Ensure failures to connect to the named pipe are propagated #6881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lsptoolshost/roslynLanguageServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,12 +629,15 @@ export class RoslynLanguageServer {
throw new Error('Timeout. Named pipe information not received from server.');
}

const socketPromise = new Promise<net.Socket>((resolve) => {
const socketPromise = new Promise<net.Socket>((resolve, reject) => {
_channel.appendLine('attempting to connect client to server...');
const socket = net.createConnection(pipeConnectionInfo.pipeName, () => {
_channel.appendLine('client has connected to server');
resolve(socket);
});

// If we failed to connect for any reason, ensure the error is propagated.
socket.on('error', (err) => reject(err));
});

// Wait for the client to connect to the named pipe.
Expand Down