Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure failures to connect to the named pipe are propagated #6881

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Ensure failures to connect to the named pipe are propagated #6881

merged 1 commit into from
Feb 13, 2024

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Feb 13, 2024 •
edited
Loading

Related to #6870

Instead of showing a timeout, we'll now output the error if the connection failed in the C# logs, e.g.

Error: connect ENOENT \\.\pipe\BAD
    at PipeConnectWrap.afterConnect [as oncomplete] (node:net:1495:16)
    at PipeConnectWrap.callbackTrampoline (node:internal/async_hooks:130:17)

@dibarbet dibarbet requested a review from a team as a code owner February 13, 2024 01:09
@dibarbet dibarbet changed the title Ensure failures to connect to the named pipe are propogated Ensure failures to connect to the named pipe are propagated Feb 13, 2024
@dibarbet dibarbet enabled auto-merge February 13, 2024 01:19
@dibarbet dibarbet merged commit f25cfb6 into dotnet:main Feb 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dibarbet @jasonmalinowski