Add support for EnableEditorConfigSupport flag #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hoffs Could you please also add a changelog entry that links to this PR and also the PR in omnisharp-roslyn |
Codecov Report
@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
+ Coverage 89.79% 89.81% +0.01%
==========================================
Files 59 59
Lines 1588 1590 +2
Branches 89 89
==========================================
+ Hits 1426 1428 +2
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
|
@Hoffs Could you also add a "Contributed by" section as we usually call out community contributions explicitly on the change log. |
Hoffs
commented
Jun 28, 2019
CHANGELOG.md
Outdated
| @@ -16,7 +16,7 @@ | |||
| * Updates to Razor support | |||
| * Made QuickInfo display more consistent with Visual Studio. ([#2610](https://github.com/OmniSharp/omnisharp-vscode/issues/2610)) (_Contributed by_ [@paladique](https://github.com/paladique))(PR: [#3090](https://github.com/OmniSharp/omnisharp-vscode/pull/3090/)) | |||
| * Added support for fading unnecessary code and using statements [#2873](https://github.com/OmniSharp/omnisharp-vscode/pull/2873) | |||
| * Added a `omnisharp.enableEditorConfigSupport` setting to enable support for .editorconfig [#3136](https://github.com/OmniSharp/omnisharp-vscode/pull/3136) (PR: [omnisharp-roslyn#1526](https://github.com/OmniSharp/omnisharp-roslyn/pull/1526)) | |||
| * Added a `omnisharp.enableEditorConfigSupport` setting to enable support for .editorconfig [#3136](https://github.com/OmniSharp/omnisharp-vscode/pull/3136) (_Contributed by_ [@hoffs](https://github.com/hoffs))(PR: [omnisharp-roslyn#1526](https://github.com/OmniSharp/omnisharp-roslyn/pull/1526)) | |||
There was a problem hiding this comment.
@akshita31 Added that as well.
There was a problem hiding this comment.
Please add @filipw for the omnisharp-roslyn PR and rebase. Thank you
Hoffs
commented
Jun 28, 2019
akshita31
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2836
Requires OmniSharp/omnisharp-roslyn#1526
Added flag:
which adds
FormattingOptions:EnableEditorConfigSupport=trueto omnisharp args